element-hq / element-hq/dendrite

The transaction_id within events is not serialised in many endpoints

Open
#3,000 3 comments 0 reactions 0 assignees View on GitHub
good first issue O-Frequent spec-compliance T-Defect
Dominant language
Go
Stars
965
Forks
101
PR merge metrics
No merged PRs in 30d

Description

*This issue was originally created by [**@sandhose**](https://github.com/sandhose) at .*

Similar to https://github.com/matrix-org/synapse/issues/15173 in Synapse

There are many endpoints that return events, and in those representations they should include the `transaction_id` in the unsigned part of the event.

I wrote a Complement test to highlight that Synapse had this issue by testing using the `/rooms/{roomId}/event/{eventId}` endpoint, and Dendrite also fails on this test. I haven't tested the other endpoints, nor covered them in the Complement test. https://github.com/matrix-org/complement/pull/621

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.