element-hq / element-hq/compound

Support primary destructive button type on Web

Open
#272 2 comments 0 reactions 0 assignees View on GitHub
P-Web T-Enhancement
Dominant language
MDX
Stars
24
Forks
7
PR merge metrics
No merged PRs in 30d

Description

Compound designs differentiate between „primary destructive“ and „secondary destructive“ buttons.

![image](https://github.com/vector-im/compound/assets/6216686/20e7552b-fa10-44bd-9df2-12abbdb06a4d)

https://www.figma.com/file/rTaQE2nIUSLav4Tg3nozq7/Compound-Web-Components?type=design&node-id=636-4&mode=design&t=RQVCJaX5SNce2GlF-0

---

Current Web implementation only supports one `kind` = `primary`, `secondary`, `tertiary` or `destructive`.

![image](https://github.com/vector-im/compound/assets/6216686/4c85e86b-1dc6-44ca-bcb0-bff838ea8c37)

---

I am happy to contribute here. But we should decide about how we do it, e.g.:
- ~Keep the `kind` prop and add an additional `destructive` or `sub-kind` prop~
- Support additional kinds `primary-destructive` and `secondary-destructive` (keep and deprecate `destructive` as alias for `secondary-destructive)

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.