element-hq / element-hq/compound
Kotlin: bgSubtleSecondaryLevel0 and bgCanvasDefaultLevel1 are treated as colors instead of semantic tokens
- Dominant language
- MDX
- Stars
- 24
- Forks
- 7
- PR merge metrics
- No merged PRs in 30d
Description
`bgSubtleSecondaryLevel0` and `bgCanvasDefaultLevel1` are semantic tokens according to @janogarcia (see: https://github.com/vector-im/compound/issues/262 ) but in Kotlin they are treated as colors:
https://github.com/vector-im/element-x-android/blob/a16335b4b754500fa046b9696a9bde285406e0e8/libraries/theme/src/main/kotlin/io/element/android/libraries/theme/compound/generated/internal/LightDesignTokens.kt#L333
https://github.com/vector-im/element-x-android/blob/a16335b4b754500fa046b9696a9bde285406e0e8/libraries/theme/src/main/kotlin/io/element/android/libraries/theme/compound/generated/internal/DarkDesignTokens.kt#L333
The code generation should be tweaked so that they are treated as semantic colors, ending up in the `SemanticColors` class instead.
Contributor guide
No contributing guide indexed for this repository
Assessment
This issue has not been assessed yet.