element-hq / element-hq/compound-web

Package version in `package.json` and git tag do not match

Open
#509 1 comment 0 reactions 0 assignees View on GitHub
Dominant language
TypeScript
Stars
35
Forks
22
Avg merge
7h 32m
Merged PRs (30d)
3

Description

**Describe the bug**
The package version in `package.json` and git tag do not match. They are off-by-one.

**To Reproduce**
Steps to reproduce the behavior:
1. Go to GH `Code` tab → Branch drop-down → Tags
2. Select the `9.0.0` tag.
3. In the Files browser, open `package.json`
4. `"version": "8.4.0"` does not match expected value `9.0.0` corresponding to tag 9.0.0.

**Expected behavior**
`version` value should match current tagged version, e.g. `9.0.0`.

**Additional context**
After looking at this further, it looks like RiotRobot writes the new version to package.json the next commit _after_ the tag where that version is introduced. Perhaps this is by design?

```
...
1fbaeed2 (origin/main, origin/HEAD) patch version bump
e9e18749 (tag: v9.4.1) fix: don't erase classname when passing props to menu item (#504)
...
3bb0f29f minor version bump
cae26b59 (tag: v9.4.0) Merge pull request #500 from element-hq/quenting/fix-form-inline-spacing
...
98e744da minor version bump
35efd19c (tag: v9.3.0) Merge pull request #488 from element-hq/hs/compound-switch-fix
fc2e6773 (github/hs/compound-switch-fix) Fix type
```

Where this matters is when downstream forks go to merge in an update based on a specific tag, but the version in package.json _at that tag_ does not match the tag, resulting in an incongruity between intended version reference and actual version reference in the lock file.

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.