element-hq / element-hq/compound-design-tokens

When syncing icons, if an Icon has been removed, the Android resource is not deleted.

Open
#257 1 comment 0 reactions 0 assignees View on GitHub
Dominant language
JavaScript
Stars
26
Forks
21
Avg merge
29m
Merged PRs (30d)
1

Description

**Describe the bug**

When syncing icons, if an Icon has been removed, the Android resource is not deleted.

**To Reproduce**
Steps to reproduce the behavior:
1. Delete an Icon from Figma
2. Sync the icons
3. Observe that the Android drawable resource is not deleted

**Expected behavior**

The Android drawable resource is not deleted

**Additional context**

See for instance in this PR: https://github.com/element-hq/compound-design-tokens/pull/249. The file `assets/android/res/drawable/ic_compound_folder.xml` should have been deleted.

A solution could be to delete all the Android resource before syncing. This is what we [do](https://github.com/element-hq/element-x-android/blob/main/tools/compound/import_tokens.sh#L33) when we import the token to Element X Android. But since the drawables are not removed from the source (this project), they are imported again, and lead to unused resources in the project EXA.

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.