electron / electron/windows-sign

2.0.2 misses files signed by 1.2.2

Open
#83 0 comments 0 reactions 0 assignees View on GitHub
bug
Dominant language
TypeScript
Stars
66
Forks
20
Avg merge
2d 1h
Merged PRs (30d)
3

Description

Two odd things.
1) it seems to not await here:

await this.codesign(options, tmpPath);

More importantly
2) only some of the files in the supplied directory are signed. Only one .exe and not others, and no .dll are signed with 2.0.2 while they are with 1.2.2.

The files signed in 1.2.2:
d3dcompiler_47.dll
dxcompiler.dll
dxil.dll
ffmpeg.dll
libEGL.dll
libGLESv2.dll
ELECTRONAPP.exe
resources\.apps\windows\x64\helper1.exe
resources\.apps\windows\x64\helper2.exe
vk_swiftshader.dll
vulkan-1.dll
resources\elevate.exe
resources\elevate.exe

The corresponding section of 2.0.2
resources\elevate.exe
resources\elevate.exe

Any clues for what is going on?

The system uses electron forge and digicert certificates on GitHub Actions and is somewhat complex, sorry I can't provide a simple demo of the problem. I've gone back to using 1.2.2.

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.