electron / electron/windows-installer

Please package `src` alongside the app

Open
#532 1 comment 0 reactions 0 assignees View on GitHub
Dominant language
TypeScript
Stars
1.6k
Forks
267
Avg merge
5h 38m
Merged PRs (30d)
1

Description

I just got a really great error message:
```
An unhandled rejection has occurred inside Forge:
Error: Failed with exit code: 1
Output:
Attempting to build package from 'aquareum_desktop.nuspec'.
'0.1.3-41ee5c4c' is not a valid version string.
Parameter name: version
at ChildProcess. (/home/iameli/code/aquareum/node_modules/electron-winstaller/src/spawn-promise.ts:51:16)
at ChildProcess.emit (node:events:520:28)
at ChildProcess.emit (node:domain:488:12)
at maybeClose (node:internal/child_process:1105:16)
at Socket. (node:internal/child_process:457:11)
at Socket.emit (node:events:532:35)
at Socket.emit (node:domain:488:12)
at Pipe. (node:net:339:12)
```

I was like, oh cool! Source maps worked correctly, I can look at the TypeScript to see what was happening when the error happened! Except I can't, because this package doesn't publish its sources. `/home/iameli/code/aquareum/node_modules/electron-winstaller/src/spawn-promise.ts` does not exist. May I suggest that adding (`tar cz src | wc -c` ==) 6473 bytes to the distributed package would make lives a bit easier?

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.