electron / electron/windows-installer

Issue with windows-sign param throwing error in Electron/windows-installer (by sea-signtool)

Open
#508 0 comments 1 reaction 0 assignees View on GitHub
Dominant language
TypeScript
Stars
1.6k
Forks
267
Avg merge
5h 38m
Merged PRs (30d)
1

Description

### Description

Using the windows-sign parameter in the `createWindowsInstaller` function of `electron/windows-installer`, seems to throw an error in `SEA_MAIN_SCRIPT`. The windows-sign parameter is added in the createWindowsInstaller function [here](https://github.com/electron/windows-installer/blob/1e6c8924bcd9abf32fa4407a3095604d7609ab6d/src/index.ts#L210C1-L214C4).

However, upon inspection of the source code of the windows-sign module, it appears that it throws an error at `SEA_MAIN_SCRIPT`, as observed here: [SEA_MAIN_SCRIPT - sea.ts](https://github.com/electron/windows-sign/blob/5ed65347464d15d8efa1b83f059f683ade4a7b07/src/sea.ts#L66). Furthermore, the error message lacks any informative details; instead, it only logs "electron-windows-sign Called with options ..." (refer to [sign.ts](https://github.com/electron/windows-sign/blob/5ed65347464d15d8efa1b83f059f683ade4a7b07/src/sign.ts#L25)). It was only after removing these logs that the actual error message became apparent: 'SignTool Error: File not found: windows-sign'."

This issue arises when using hookModulePath.

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.