electron / electron/windows-installer

Incorrect .ico used for Desktop and Start menu shortcuts

Open
#365 6 comments 6 reactions 0 assignees View on GitHub
Dominant language
TypeScript
Stars
1.6k
Forks
267
Avg merge
5h 38m
Merged PRs (30d)
1

Description

Hi all :wave:

I am using Electron Forge (specifically the @electron-forge/maker-squirrel module) to create an installer package for a Win32 architecture. I apologize if this is not the correct place for this issue, but I know "windows-installer" is the underlying module used by Electron Forge which is why I'm here.

I have successfully packaged the application and can install/uninstall it from my machine no problem. However, I have some issues with the Start Menu, Taskbar, and Desktop Shortcut icons.

1.) Executing the app using my ```npm start (electron-forge start)``` script

- Start Menu - Not applicable ➖
- Desktop Shortcut - Not applicable ➖
- Taskbar - Icon shows how I would expect. ✔️
- Add/Remove Program List - Not applicable ➖

2.) First time installing the application using the packaged "app_setup.exe", followed by the application opening for the first time

- Start Menu - Shortcut created, but uses the Atom icon ❌
- Desktop Shortcut - Shortcut created, but uses the Atom icon ❌
- Taskbar - Icons shows how I would expect. ✔️
- Add/Remove Program List - Icon shows how I would expect. ✔️

3.) nth time executing the app, using the Start Menu or Desktop Shortcut (Not the first time)

- Start Menu - Shortcut is still the Atom icon ❌
- Desktop Shortcut - Shortcut is still the Atom icon ❌
- Taskbar - Icon now shows the Atom icon ❌
- Add/Remove Program List - Icon shows how I would expect. ✔️

## Package versions
**electron version: 10.1.4**
**maker-squirrel version: 6.0.0-beta.54**

## maker-squirrel config
```json
"config": {
"authors": "Stephen Murphy",
"description": "Open-Source Cross-Platform Serial Monitor written using Electron and NodeJS",
"exe": "serial_dev.exe",
"name": "serial_dev",
"noMsi": false,
"setupExe": "serial_dev_setup.exe",
"title": "Serial Dev",
"iconUrl": "https://electronassets.s3.us-east-2.amazonaws.com/thunder_32x32.ico"
}
```

## Install directory
![image](https://user-images.githubusercontent.com/26120817/99153100-563f8f80-2674-11eb-9dca-a2aad94bc431.png)

## SquirrelSetup Contents
```
2020-11-14 12:23:54> Program: Starting Squirrel Updater: --createShortcut=serial_dev.exe
2020-11-14 12:23:54> ApplyReleasesImpl: About to create shortcuts for serial_dev.exe, rootAppDir C:\Users\steph\AppData\Local\serial_dev
2020-11-14 12:23:54> ApplyReleasesImpl: Creating shortcut for serial_dev.exe => C:\Users\steph\AppData\Roaming\Microsoft\Windows\Start Menu\Programs\GitHub, Inc.\serial_dev.lnk
2020-11-14 12:23:54> ApplyReleasesImpl: About to save shortcut: C:\Users\steph\AppData\Roaming\Microsoft\Windows\Start Menu\Programs\GitHub, Inc.\serial_dev.lnk (target C:\Users\steph\AppData\Local\serial_dev\serial_dev.exe, workingDir C:\Users\steph\AppData\Local\serial_dev\app-1.2.0, args , toastActivatorCSLID aaddbfbd-e30c-5a55-b3aa-1fc98b148508)
2020-11-14 12:23:54> ApplyReleasesImpl: Creating shortcut for serial_dev.exe => C:\Users\steph\Desktop\serial_dev.lnk
2020-11-14 12:23:54> ApplyReleasesImpl: About to save shortcut: C:\Users\steph\Desktop\serial_dev.lnk (target C:\Users\steph\AppData\Local\serial_dev\serial_dev.exe, workingDir C:\Users\steph\AppData\Local\serial_dev\app-1.2.0, args , toastActivatorCSLID aaddbfbd-e30c-5a55-b3aa-1fc98b148508)
2020-11-14 12:23:54> ApplyReleasesImpl: Examining Pin: Altium Designer.lnk
2020-11-14 12:23:54> ApplyReleasesImpl: Examining Pin: File Explorer.lnk
2020-11-14 12:23:54> ApplyReleasesImpl: Examining Pin: Firefox.lnk
2020-11-14 12:23:54> ApplyReleasesImpl: Examining Pin: Google Chrome.lnk
2020-11-14 12:23:54> ApplyReleasesImpl: Examining Pin: Visual Studio Code.lnk
2020-11-14 12:23:54> ApplyReleasesImpl: Examining Pin: Windows PowerShell (x86).lnk
```

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.