electron / electron/windows-installer
Support for semantic version prerelease version format
- Dominant language
- TypeScript
- Stars
- 1.6k
- Forks
- 267
- Avg merge
- 5h 38m
- Merged PRs (30d)
- 1
Description
I recently came across an interesting issue where I was building an app with electron-forge and uploading it to nucleus when the nucleus server rejected a file saying that it could not find the version in the file.
This build was from a prerelease version which means that the version format was like `app.org-1.0.0-beta.3`
So I had two files that I was uploading:
```
app.org-1.0.0-beta.3 Setup.exe
app.org-1.0.0-beta3-full.nupkg
```
Now this is interesting because I'm guessing that the reason is to support the required nuget package without running into this issue: https://github.com/Squirrel/Squirrel.Windows/issues/523
However this version structure of `1.0.0-beta.3` is the semantic version standard for prereleases.
Here is the line that I believe is reformatting the version.
https://github.com/electron/windows-installer/blob/1350a1695e3e8a57ed742e3034ee144d32feb64d/src/index.ts#L18
I was wondering if this is something that's absolutely necessary or if it's possible to support the prerelease formatting.
Any advice or help would be greatly appreciated.
Contributor guide
No contributing guide indexed for this repository
Assessment
This issue has not been assessed yet.