electron / electron/windows-installer

Sign Windows application with external tool

Open
#174 4 comments 0 reactions 0 assignees View on GitHub
Dominant language
TypeScript
Stars
1.6k
Forks
267
Avg merge
5h 38m
Merged PRs (30d)
1

Description

in #109 @paulcbetts wrote: "It signs all of your executables and update.exe, then signs the outer MSI/EXE"

Is it possible to sign the executables with a different tool? We have an enterprise application signing tool that keeps certificates off of our development machines.

I am writing code to

1. run electron-packager on our project
2. sign the output of electron-packager
3. call electron-wininstaller to create the installer
4. sign the output of electron-wininstaller

Unfortunately, update.exe is not available in any of these steps.

A separate issue that the `resources/*.asar` files are not signed. This leaves a potential attack vector open. https://github.com/electron-userland/electron-packager/issues/656

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.