electron / electron/windows-installer

is it possible codesign windows installer on OSX?

Open
#172 4 comments 0 reactions 0 assignees View on GitHub
Dominant language
TypeScript
Stars
1.6k
Forks
267
Avg merge
5h 38m
Merged PRs (30d)
1

Description

```javascript
const electronInstaller = require('electron-winstaller');
const path = require('path');
const fs = require('fs');
const appDirectory = 'foo'
const outputDirectory = 'foo'
const loadingGif = 'foo'
const setupIcon = 'foo'
const iconUrl = 'foo'
const certificateFile = '%SOME_PATH%' // i'm using .pfx file

resultPromise = electronInstaller.createWindowsInstaller({
appDirectory,
outputDirectory,
loadingGif,
setupIcon,
iconUrl,
name: "FOO",
description: "FOO",
authors: 'COM',
exe: 'FOO.exe',
setupExe: 'FOO.exe',
certificateFile: certificateFile,
certificatePassword: 'XXXXX'
});
```

- i'm using .pfx file

error stacktrace
```bash
No dice: Failed with exit code: 255
Output:
System.AggregateException: One or more errors occurred. ---> System.Exception: Failed to sign, command invoked was: '/Users/baegjaehyeon/Code/work/desktop/xxxx-desktop/node_modules/electron-winstaller/vendor/signtool.exe sign /a /f "/Users/baegjaehyeon/certificate/xxxx.co.kr.pfx" /p "xxxx" /Users/baegjaehyeon/.local/share/SquirrelTemp/tempa/lib/net45/libEGL.dll'
(...)
```

i think, beacuse of this library using 'signtool.exe', i have this problem.
is it possible codesigning on osx?

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.