electron / electron/update.electronjs.org
Support monorepos by coercing version strings
Open
- Dominant language
- TypeScript
- Stars
- 698
- Forks
- 82
- Avg merge
- 9h 16m
- Merged PRs (30d)
- 3
Description
The updater currenty relies on `semver.valid` to determine whether incoming version strings are valid. It does this for the parsed URL as well as the tags from GitHub releases.
Monorepos have to uses more complex tag prefixes, since they can contain many projects that each have a different version. The typical format is `package-name@0.1.2`.
If the updater were to clean putative version strings with `semver.coerce`, that would solve this problem.
It looks like that would be an easy update -- if the feature is wanted I can make a PR!
Contributor guide
No contributing guide indexed for this repository
Assessment
This issue has not been assessed yet.