electron / electron/universal

ffmpeg module does not rebuild according to `arch`

Open
#106 2 comments 0 reactions 0 assignees View on GitHub
Dominant language
TypeScript
Stars
148
Forks
47
Avg merge
3h 57m
Merged PRs (30d)
5

Description

We are using `ffmpeg-static` in our Electron app, but when the universal build is created, only the arm64 ffmpeg binary exists. I have confirmed that the `ffmpeg-static` module can be rebuilt with an arch param (`npm rebuild --arch=arm64 -f ffmpeg-static`, then confirmed with `file node_modules/ffmpeg-static/ffmpeg`) and the correct binary is created/downloaded. But when running the universal build, only os.arch() seems to be respected (which is an M1 machine in CircleCI).

If there were hooks in the universal build process, or some env vars set, I could manually rebuild this one module according to an arch. For example this ffmpeg module does read `process.env.npm_config_arch`, so if I were able to set that in between the x64 and arm64 builds (or `electron/universal` did), the module would build the correct ffmpeg binary.

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.