electron / electron/rebuild

Not working for packages without a binding.gyp file

Open
#646 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
TypeScript
Stars
1.1k
Forks
181
Avg merge
6h 44m
Merged PRs (30d)
3

Description

`electron-rebuild` only works on packages that include a `binding.gyp` file -> [rebuild.ts#L243](https://github.com/electron/electron-rebuild/blob/master/src/rebuild.ts#L243)

But this file is not necessary for packages that only rely on prebuilts distribution (ie. when there is no source code available in the package itself). So trying to rebuild those packages will silently fail even if they are eligible native Node.js modules.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.