electron / electron/rebuild

GCC_PREFIX_HEADER & GCC_PRECOMPILE_PREFIX_HEADER incompatible with Electron 20

Open
#1,069 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
TypeScript
Stars
1.1k
Forks
181
Avg merge
6h 44m
Merged PRs (30d)
3

Description

https://github.com/electron/rebuild/blob/29365ad904a8713567c4a7beb745d32df7f229e1/src/clang-fetcher.ts#L46

Hi --

I believe (not 100% sure) that this line of code is to blame. PCH (precompiled headers) need to be generated for every language in the project (c, c++, etc). I have a project that has a couple c files and is mostly c++. But the precompiled header is being compiled with -std=c++17 even for the c version of the header, which errors.

I'm not sure what the best solution is.

This issue arises on Mac as GCC_PREFIX_HEADER is part of XCODE_SETTINGS

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.