electron / electron/packager

Set Icon for Helper app

Open
#955 3 comments 0 reactions 0 assignees View on GitHub
build-target:mac :apple: enhancement help wanted
Dominant language
TypeScript
Stars
302
Forks
42
Avg merge
5h 40m
Merged PRs (30d)
7

Description

* [x] I have read the [contribution documentation](https://github.com/electron-userland/electron-packager/blob/master/CONTRIBUTING.md) for this project.
* [x] I agree to follow the [code of conduct](https://github.com/electron/electron/blob/master/CODE_OF_CONDUCT.md) that this project follows, as appropriate.
* [x] I have searched the issue tracker for an issue that matches the one I want to file, without success.

**Please describe your issue:**

On MacOS, If you trigger a User Notification from a renderer process (e.g. via a Native Addon), the notification is given a placeholder icon, because the owning .app (the Helper) lacks an icon.

![image](https://user-images.githubusercontent.com/1938545/53305537-99c6ea00-3850-11e9-912e-7f6f76526aba.png)

If you specify an Icon, that Icon should also be used for the Helper Apps, or there should be an option to specify the Helper app icon separately.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.