electron / electron/node-minidump

Missing `yarn` dependency?

Open
#93 1 comment 0 reactions 0 assignees View on GitHub
Dominant language
JavaScript
Stars
79
Forks
45
Avg merge
12h 18m
Merged PRs (30d)
1

Description

`package.json` install script references `yarn`, but none of the dependencies install it, should it be added there? Running `npm i minidump` as instructed in the README generates the following error:
```
npm error command sh -c yarn submodule && node build.js
npm error sh: 1: yarn: not found
```

Running `npm i yarn` before trying to install minidump seems to help (`yarn@1.22.22` for `minidump@0.26.0` worked for me at the time of writing this report).

Happy to make a PR if it's as simple as adding it to package.json (but I admit I know nothing about yarn and if there's some reason you wouldn't want to do that as there often seems to be with overenthusiastic build systems ^_^)

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.