Make the webpack magic constants work nicer with typescript
Open
plugin/webpack
typescript
- Dominant language
- TypeScript
- Stars
- 7.1k
- Forks
- 641
- Avg merge
- 3d 1h
- Merged PRs (30d)
- 30
Description
Currently the magic webpack constants require manual `declare var MAGIC_CONSTANT: string` declarations if your project uses typescript.
We should either .
(a) Change the implementation of these constants so they are a magic module that actually exists on disk with types. E.g. `import { CONSTANT } from '@electron-forge/webpack-constants'`
(b) Document the need for the `declare var` so people avoid this issue / can at least solve it.
Contributor guide
Assessment
This issue has not been assessed yet.