electron / electron/forge

Support pnpm workspace

Open
#4,188 3 comments 14 reactions 0 assignees View on GitHub
Dominant language
TypeScript
Stars
7.1k
Forks
641
Avg merge
3d 17m
Merged PRs (30d)
32

Description

### Pre-flight checklist

- [x] I have read the [contribution documentation](https://github.com/electron/forge/blob/main/CONTRIBUTING.md) for this project.
- [x] I agree to follow the [code of conduct](https://github.com/electron/electron/blob/main/CODE_OF_CONDUCT.md) that this project uses.
- [x] I have searched the issue tracker for a feature request that matches the one I want to file, without success.

### Problem description

When using pnpm, forge requires `node-linker=hoisted` in the project's .npmrc configuration. If the project is a monorepo with electorn inside e.g `root/app`, node-linker=hoisted means all node-modules are hoisted into the `root/node_modules`.
However electron-forge expects the node-modules to be present in the apps-root (`root/app/node_modules`) and therewith wont resolve native modules during build...

### Proposed solution

Support linked node-modules to be compatible with pnpm stores

### Alternatives considered

-

### Additional information

_No response_

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.