electron / electron/forge

Maker MSIX doesn't use the Config

Open
#4,060 2 comments 0 reactions 0 assignees View on GitHub
bug maker/msix
Dominant language
TypeScript
Stars
7.1k
Forks
641
Avg merge
3d 1h
Merged PRs (30d)
30

Description

### Pre-flight checklist

- [x] I have read the [contribution documentation](https://github.com/electron/forge/blob/main/CONTRIBUTING.md) for this project.
- [x] I agree to follow the [code of conduct](https://github.com/electron/electron/blob/main/CODE_OF_CONDUCT.md) that this project uses.
- [x] I have searched the issue tracker for a bug that matches the one I want to file, without success.

### Forge version

7.6.0

### Electron version

v33.3.0

### Operating system

Windows 11 (22631)

### Last known working Forge version

_No response_

### Expected behavior

The MakerMSIX package isn't taking the passed in config and modifying what it passes to the underlying package it uses.

### Actual behavior

It only passes the default config because this.config is an empty object.

### Steps to reproduce

Attempt to make any build with some sort of configuration passed to the MakerMSIX.

### Additional information

I have attempted to use both a factory for the config and a regular object.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.