electron / electron/forge

error TS2307: Cannot find module 'rxjs' or its corresponding type declarations

Open
#3,878 1 comment 0 reactions 0 assignees View on GitHub
dependencies typescript
Dominant language
TypeScript
Stars
7.1k
Forks
641
Avg merge
3d 1h
Merged PRs (30d)
30

Description

### Pre-flight checklist

- [x] I have read the [contribution documentation](https://github.com/electron/forge/blob/main/CONTRIBUTING.md) for this project.
- [x] I agree to follow the [code of conduct](https://github.com/electron/electron/blob/main/CODE_OF_CONDUCT.md) that this project uses.
- [x] I have searched the issue tracker for a bug that matches the one I want to file, without success.

### Forge version

7.7.0

### Electron version

34.2.0

### Operating system

PopOS! 22.04 x64

### Last known working Forge version

_No response_

### Expected behavior

No TypeScript compilation errors

### Actual behavior

```
node_modules/listr2/dist/index.d.ts:1:28 - error TS2307: Cannot find module 'rxjs' or its corresponding type declarations.

1 import { Observable } from 'rxjs';
~~~~~~
```

### Steps to reproduce

Run `npx tsc --noEmit` on the vite + typescript template

### Additional information

Solution: update `listr2` to version "^8.1.0" (i.e. by changing https://github.com/electron/forge/blob/aee077fff1747a80d4a72dc081a5598c11cf928e/package.json#L63) so that this project and its users can benefit from this `listr2` fix: https://github.com/listr2/listr2/commit/4eab16a21ae84fd114216931394af86ceda1576e .

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.