electron / electron/forge

Mixed up files when using multiple makers: Squirrel files end up in the zip

Open
#3,870 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
TypeScript
Stars
7.1k
Forks
641
Avg merge
3d 1h
Merged PRs (30d)
30

Description

### Pre-flight checklist

- [x] I have read the [contribution documentation](https://github.com/electron/forge/blob/main/CONTRIBUTING.md) for this project.
- [x] I agree to follow the [code of conduct](https://github.com/electron/electron/blob/main/CODE_OF_CONDUCT.md) that this project uses.
- [x] I have searched the issue tracker for a bug that matches the one I want to file, without success.

### Forge version

7.7.0

### Electron version

35.0.0

### Operating system

Windows

### Last known working Forge version

_No response_

### Expected behavior

When using multiple makers, each installer should go in its own output directory.

### Actual behavior

Output files get mixed up.

### Steps to reproduce

Start from a template:

`npx create-electron-app@latest my-app --template=webpack-typescript`

Modify forge.config.ts to have two makers (by default, there's a single one on Windows):

```
// ...
makers: [new MakerSquirrel({}), new MakerZIP({})],
// ...
```

Generate distributables:

`electron-forge make`

In the zip archive, there's a Squirel.exe binary.

![Image](https://github.com/user-attachments/assets/bf46a821-2d4c-4c51-a207-b7164557e56a)

### Additional information

_No response_

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.