electron / electron/forge

publisher-electron-release-server GET await (await authFetch('versions/sorted')).json(); in PublisherERS.ts this call (versions/sorted) has a limit of versions on key "items".

Open
#3,698 0 comments 0 reactions 0 assignees View on GitHub
bug publisher/ers
Dominant language
TypeScript
Stars
7.1k
Forks
641
Avg merge
3d 1h
Merged PRs (30d)
30

Description

### Pre-flight checklist

- [X] I have read the [contribution documentation](https://github.com/electron/forge/blob/main/CONTRIBUTING.md) for this project.
- [X] I agree to follow the [code of conduct](https://github.com/electron/electron/blob/main/CODE_OF_CONDUCT.md) that this project uses.
- [X] I have searched the issue tracker for a bug that matches the one I want to file, without success.

### Electron Forge version

7.4.0

### Electron version

32.1.0

### Operating system

macOS 13.6.9 (22G830)

### Last known working Electron Forge version

_No response_

### Expected behavior

Behavior is similar to that described in https://github.com/electron/forge/issues/3430

### Actual behavior

The problem is similar to that described in https://github.com/electron/forge/issues/3430.

+ similar behavior if we do not create a zip and dmg package. But we collect versions for darwin_x64 and darwin_arm64 architecture within one process on pnpm run publish.

Except that now we are not limited to the 30 versions returned by the old authFetch('api/version') endpoint.

But to the number of elements available for return in the authFetch('versions/sorted') endpoint, if we add an update to an older version. Since in the first N (default: 50), sorted by version name, we do not get the newly created one.

This number is regulated on the electron-release-server side. https://github.com/ArekSredzki/electron-release-server/blob/master/config/views.js#L46
As a temporary solution, we can permanently increase this limit, but at the same time we increase the time until electron-release-server makes all the selection of files we need, which slows down the process of building our application.

### Steps to reproduce

Create versions greater than specified in your electron-release-server settings https://github.com/ArekSredzki/electron-release-server/blob/master/config/views.js#L46.

Attempt to build a new version with a name less than the last one returned in the authFetch('versions/sorted') endpoint

### Additional information

_No response_

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.