vite-plugin unable to make/package
- Dominant language
- TypeScript
- Stars
- 7.1k
- Forks
- 641
- Avg merge
- 3d 1h
- Merged PRs (30d)
- 30
Description
### Pre-flight checklist
- [X] I have read the [contribution documentation](https://github.com/electron/forge/blob/main/CONTRIBUTING.md) for this project.
- [X] I agree to follow the [code of conduct](https://github.com/electron/electron/blob/main/CODE_OF_CONDUCT.md) that this project uses.
- [X] I have searched the issue tracker for a bug that matches the one I want to file, without success.
### Electron Forge version
7.4.0
### Electron version
31.2.1
### Operating system
macOS 14.5
### Last known working Electron Forge version
_No response_
### Expected behavior
Able to package and make via electron forge cli on macOS using DMG @electron-forge/maker-dmg": "^7.4.0",
### Actual behavior
So I created a new project using the template.
`npm init electron-app@latest my-new-app -- --template=vite-typescript`
This uses the latest template of 7.4.0, building and running works fine. I then add some packages that seem to cause this behavior.
I run `yarn make` it fails, so I enable debugging via `export DEBUG=electrion-*`
Run it again and get the following
```
An unhandled rejection has occurred inside Forge:
Error: Cannot copy '../../../markdown-it/bin/markdown-it.mjs' to a subdirectory of itself, '../../../markdown-it/bin/markdown-it.mjs'.
at /Users/alex.pham/Documents/Git/vitelasttry/my-new-app/node_modules/fs-extra/lib/copy/copy.js:213:21
at FSReqCallback.oncomplete (node:fs:193:23)
error Command failed with exit code 1.
```
### Steps to reproduce
1. create new project
`npm init electron-app@latest my-new-app -- --template=vite-typescript`
2. add dmg maker
`yarn add @electron-forge/maker-dmg`
3. edit forge.config.ts replace zip maker with DMG maker
` makers: [
new MakerSquirrel({}),
new MakerDMG(),
new MakerRpm({}),
new MakerDeb({}),
],`
4. add this dependency
`yarn add @atlaskit/editor-common`
5. make the project
`yarn make`
### Additional information
Seems to be related to this issue
https://github.com/electron/asar/pull/308
however I checked my yarn.lock file and see that @electron/asar points to version 3.2.10 which should be the version that fixed the possible symlink issue.
Contributor guide
Assessment
This issue has not been assessed yet.