electron / electron/forge

Remove hardcoded `node_modules`

Open
#3,630 1 comment 0 reactions 0 assignees View on GitHub
bug plugin/vite
Dominant language
TypeScript
Stars
7.1k
Forks
641
Avg merge
3d 1h
Merged PRs (30d)
30

Description

### Pre-flight checklist

- [X] I have read the [contribution documentation](https://github.com/electron/forge/blob/main/CONTRIBUTING.md) for this project.
- [X] I agree to follow the [code of conduct](https://github.com/electron/electron/blob/main/CODE_OF_CONDUCT.md) that this project uses.
- [X] I have searched the issue tracker for a bug that matches the one I want to file, without success.

### Electron Forge version

7.4.0

### Electron version

31.0.1

### Operating system

Windows 11

### Last known working Electron Forge version

_No response_

### Expected behavior

`node_modules` isn't used

### Actual behavior

`node_modules` is used

### Steps to reproduce

- `git clone https://github.com/rtritto/template-electron-vite.git`
- `cd template-electron-vite`
- `yarn`
- `yarn start`
- `node_modules/.vite` foders is created even if `cacheDir` is `.vite/cache` (issue https://github.com/vitejs/vite/issues/17491)

### Additional information

This issue also create some problem with Plug'n'Play (PnP) node linker.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.