electron / electron/forge

plugin-vite - Error: Cannot copy '../which/bin/node-which' to a subdirectory of itself, '../which/bin/node-which'.

Open
#3,602 2 comments 0 reactions 0 assignees View on GitHub
bug plugin/vite
Dominant language
TypeScript
Stars
7.1k
Forks
641
Avg merge
3d 1h
Merged PRs (30d)
30

Description

### Pre-flight checklist

- [X] I have read the [contribution documentation](https://github.com/electron/forge/blob/main/CONTRIBUTING.md) for this project.
- [X] I agree to follow the [code of conduct](https://github.com/electron/electron/blob/main/CODE_OF_CONDUCT.md) that this project uses.
- [X] I have searched the issue tracker for a bug that matches the one I want to file, without success.

### Electron Forge version

7.4.0

### Electron version

v30.0.6

### Operating system

Pop!_OS by System76 (Latest)

### Last known working Electron Forge version

Bare version with just HTML and JS, e.g. No Vite + TS

### Expected behavior

`npm run make` does not error out on Linux & Mac & Windows in CI with Vite + TS.

### Actual behavior

`npm run make` DOES error out on Linux & Mac in CI.

### Steps to reproduce

1. `git clone https://github.com/mistweaverco/timetrack && cd timetrack`
2. `git checkout v3.3.0`
3. `npm ci`
4. `npm run make`

### Additional information

Seems to be due to a bug in `fs-extra` in the `vite-plugin`.

![image](https://github.com/electron/forge/assets/1384938/466e7a18-6c80-40e0-8ee3-61ae483f67d5)

I patched it [here](https://github.com/mistweaverco/timetrack/pull/28) for my project, but probably you guys and girls can also fork `fs-extra` and patch it and use your patched version of it?!

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.