electron / electron/forge

packagerConfig.appVersion is not working in makers

Open
#3,523 1 comment 2 reactions 0 assignees View on GitHub
bug maker/dmg
Dominant language
TypeScript
Stars
7.1k
Forks
641
Avg merge
3d 1h
Merged PRs (30d)
30

Description

### Pre-flight checklist

- [X] I have read the [contribution documentation](https://github.com/electron/forge/blob/main/CONTRIBUTING.md) for this project.
- [X] I agree to follow the [code of conduct](https://github.com/electron/electron/blob/main/CODE_OF_CONDUCT.md) that this project uses.
- [X] I have searched the issue tracker for a bug that matches the one I want to file, without success.

### Electron Forge version

7.3.0

### Electron version

v29.0.1

### Operating system

macOS

### Last known working Electron Forge version

_No response_

### Expected behavior

Makers use `packagerConfig.appVersion` as output path

### Actual behavior

Makers use `packageJSON.version` instead of `packagerConfig.appVersion` as output path

### Steps to reproduce

https://github.com/electron/forge/blob/1aa94fc32754ffd07a3652db42952f1f22ddbd6c/packages/maker/dmg/src/MakerDMG.ts#L22

### Additional information

_No response_

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.