electron / electron/forge

S3 Publisher can't be configured to prevent overwriting existing uploads if they exist

Open
#3,328 0 comments 0 reactions 0 assignees View on GitHub
publisher/s3
Dominant language
TypeScript
Stars
7.1k
Forks
641
Avg merge
3d 1h
Merged PRs (30d)
30

Description

### Pre-flight checklist

- [X] I have read the [contribution documentation](https://github.com/electron/forge/blob/main/CONTRIBUTING.md) for this project.
- [X] I agree to follow the [code of conduct](https://github.com/electron/electron/blob/main/CODE_OF_CONDUCT.md) that this project uses.
- [X] I have searched the issue tracker for a feature request that matches the one I want to file, without success.

### Problem description

At the moment it's possible for an artifact to be uploaded over top of previous artifact.

### Proposed solution

It would be fantastic if the s3 publisher was more customizable. Either allowing middleware to be supplied directly by the user, or by having a config option that supplies the `If-None-Match: *` header to s3 when uploading.

https://stackoverflow.com/a/76596824

### Alternatives considered

In the key resolver step you can make a request to check if something is already on the server… Though that requires synchronously executing an http request.

Downsides:
* Complexity
* Race condition

### Additional information

_No response_

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.