electron / electron/forge

Chinese ProductName Garbled & Chinese ProductName with setupIcon building failed

Open
#3,318 5 comments 0 reactions 0 assignees View on GitHub
bug maker/squirrel platform/windows
Dominant language
TypeScript
Stars
7.1k
Forks
641
Avg merge
3d 1h
Merged PRs (30d)
30

Description

### Pre-flight checklist

- [X] I have read the [contribution documentation](https://github.com/electron/forge/blob/main/CONTRIBUTING.md) for this project.
- [X] I agree to follow the [code of conduct](https://github.com/electron/electron/blob/main/CODE_OF_CONDUCT.md) that this project uses.
- [X] I have searched the issue tracker for a bug that matches the one I want to file, without success.

### Electron Forge version

6.4.1

### Electron version

v26.0.0

### Operating system

Windows 10

### Last known working Electron Forge version

6.4.1

### Expected behavior

Chinese characters display normally and are build normally

### Actual behavior

Chinese ProductName Garbled & Chinese ProductName with setupIcon building failed

### Steps to reproduce

package.json -> "productName": "测试中文名"
forge.config.js -> makers -> @electron-forge/maker-squirrel -> config -> { setupIcon: 'setupIcon path' }

ref issue #3176 #2443

Guess it may be related to the Squirrel tool, as the exe name generated under out/{productname}win32-x64/ before the electron forge was made can display Chinese normally

### Additional information

_No response_

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.