Remove double quotes from the signWithParams description when building the MSI installer
- Dominant language
- TypeScript
- Stars
- 7.1k
- Forks
- 641
- Avg merge
- 3d 1h
- Merged PRs (30d)
- 30
Description
### Pre-flight checklist
- [X] I have read the [contribution documentation](https://github.com/electron/forge/blob/main/CONTRIBUTING.md) for this project.
- [X] I agree to follow the [code of conduct](https://github.com/electron/electron/blob/main/CODE_OF_CONDUCT.md) that this project uses.
- [X] I have searched the issue tracker for a feature request that matches the one I want to file, without success.
### Problem description
For @electron-forge/maker-wix, when using `signWithParams` in the `package.json` to configure the description for the MSI installer and possibly others, any double quotes used for escaping will be displayed in the final output. For example:
`"signWithParams": "/a /tr http://timestamp.globalsign.com/tsa/r6advanced1 /td SHA256 /fd SHA256 /d \"Space Separated Description\""`
This configuration results in the description being displayed as `"Space Separated Description"` with the double quotes. Ideally, we would like to remove these double quotes and display the description as `Space Separated Description`.
### Proposed solution
Please consider adding a feature or workaround to remove the double quotes from the description when building the MSI installer, while still adhering to JSON syntax rules.
### Alternatives considered
An alternative solution is to use a build script that reads the package.json file and replaces the description value with the desired format without double quotes before executing the build process. However, it would be more convenient to have a built-in solution.
### Additional information
_No response_
Contributor guide
Assessment
This issue has not been assessed yet.