electron / electron/forge

maker-deb config.depends has no effect

Open
#3,127 2 comments 0 reactions 0 assignees View on GitHub
config maker/deb
Dominant language
TypeScript
Stars
7.1k
Forks
641
Avg merge
3d 1h
Merged PRs (30d)
30

Description

### Pre-flight checklist

- [X] I have read the [contribution documentation](https://github.com/electron/forge/blob/main/CONTRIBUTING.md) for this project.
- [X] I agree to follow the [code of conduct](https://github.com/electron/electron/blob/main/CODE_OF_CONDUCT.md) that this project uses.
- [X] I have searched the issue tracker for a bug that matches the one I want to file, without success.

### Electron Forge version

6.0.4

### Electron version

18.3.6

### Operating system

Linux x64

### Last known working Electron Forge version

_No response_

### Expected behavior

config.depends should work.

### Actual behavior

config.depends not working.

### Steps to reproduce

forge.config.js:
```
makers: [
{
name: '@electron-forge/maker-deb',
config: {
depends: ['libopencv-dev']
}
}
]
```

### Additional information

Looks like the problem is here:
https://github.com/electron/forge/blob/main/packages/maker/deb/src/MakerDeb.ts#L42
https://github.com/electron-userland/electron-installer-debian/blob/main/src/installer.js#L173
https://github.com/electron-userland/electron-installer-common/blob/master/src/dependencies.js#L126
Here leaves an empty options object during initialization.
This makes the merge option use empty content.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.