electron / electron/forge

In WIX MSI mode, appIconPath cannot be set in package.json

Open
#2,547 0 comments 0 reactions 0 assignees View on GitHub
config maker/msi platform/windows
Dominant language
TypeScript
Stars
7.1k
Forks
641
Avg merge
3d 17m
Merged PRs (30d)
32

Description

### Pre-flight checklist

- [X] I have read the [contribution documentation](https://github.com/electron-userland/electron-forge/blob/master/CONTRIBUTING.md) for this project.
- [X] I agree to follow the [code of conduct](https://github.com/electron/electron/blob/main/CODE_OF_CONDUCT.md) that this project uses.
- [X] I have searched the issue tracker for a feature request that matches the one I want to file, without success.

### Problem description

I have already browsed https://js.electronforge.io/maker/wix/interfaces/makerwixconfig

After I generated my program and installed it, my icon is not consistent with the actual one

Like this:
![image](https://user-images.githubusercontent.com/43660020/134789920-a5923e40-4462-44ab-ae0d-3df2f72be525.png)

appIconPath cannot be set in package.json

### Proposed solution

add appIconPath to MSICreatorOptions (packages/maker/wix/src/Config.ts)

### Alternatives considered

1、It can be set using JavaScript script, but it is not easy to maintain
2、It may be possible to automatically set this value to {packagerConfig.icon}, but it may cause incompatibility with old projects, so it is not recommended
"packagerConfig": {
"icon":"favicon.ico"
},

### Additional information

_No response_

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.