electron / electron/forge

Add InnoSetup make Target

Open
#226 9 comments 3 reactions 0 assignees View on GitHub
request/maker
Dominant language
TypeScript
Stars
7.1k
Forks
641
Avg merge
3d 1h
Merged PRs (30d)
30

Description

* [x] I have read the [contribution documentation](https://github.com/electron-userland/electron-forge/blob/master/CONTRIBUTING.md) for this project.
* [x] I agree to follow the [code of conduct](https://github.com/electron/electron/blob/master/CODE_OF_CONDUCT.md) that this project follows, as appropriate.
* [x] I have searched the issue tracker for an issue that matches the one I want to file, without success.

**Please describe your issue:**
I'd like to see some alternative make targets on Windows, Squirrel's windows installer does not offer the user feedback or customizable install I am looking to offer so at the moment I am using `forge` to package and InnoSetup to create installer [see this repo for the setup](https://github.com/ValenceEncoder/Valence.git). The end product installer is a more user-friendly and familiar experience than Squirrel currently offers. It's also got some easy to integrate toolchain stuff like a CLI and some [node wrappers](https://www.npmjs.com/package/innosetup-compiler)

If this is something that you think would benefit `electron-forge`, I'd be happy to work on it but would be good to get some pointers on where in the codebase to start.

If you don't think InnoSetup is suitable for `electron-forge` please feel free to close this issue.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.