electron / electron/fiddle

feat: in batch mode, fiddle should log a full URL of the gist being run

Open
#800 0 comments 0 reactions 1 assignee Claimed by @ckerr View on GitHub
:sparkles: enhancement
Dominant language
TypeScript
Stars
7.8k
Forks
762
Avg merge
15h 27m
Merged PRs (30d)
12

Description

draft version:

```diff
diff --git a/src/renderer/task-runner.ts b/src/renderer/task-runner.ts
index b705834..4b6bbe0 100644
--- a/src/renderer/task-runner.ts
+++ b/src/renderer/task-runner.ts
@@ -14,6 +14,7 @@ import { AppState } from './state';

import { getVersionRange } from '../utils/get-version-range';
import { normalizeVersion } from '../utils/normalize-version';
+import { urlFromId } from '../utils/gist';

import { ipcRendererManager } from './ipc';

@@ -130,7 +131,12 @@ export class TaskRunner {
}

if (fiddle) {
- log(`Task: Open fiddle \"${JSON.stringify(fiddle)}"`);
+ const { gistId } = fiddle;
+ if (gistId) {
+ log(`Task: Open fiddle "${gistId}" ("${urlFromId(gistId)}")`);
+ } else {
+ log(`Task: Open fiddle "${JSON.stringify(fiddle)}"`);
+ }
await this.open(fiddle);
}
}
```

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.