electron-userland / electron-userland/electron-webpack

electron-webpack issue on --env.production parameter

Open
#448 1 comment 0 reactions 0 assignees View on GitHub
Dominant language
TypeScript
Stars
902
Forks
168
PR merge metrics
No merged PRs in 30d

Description

* **Version**:
@expo/electron-adapter": "0.0.55"
electron: "13.1.2"
electron-builder: "22.11.7"

No electron-updater used

* **Target**:
Mac, Win and Linux (same issue)

image
When attempting to build for Mac/Win/Linux , the electron-webpack somehow does not handle the absence of the --env.production parameter that from my scripts is not even explicitly declared
image
Commenting the lines in the screenshot solves the problem and allows me to build on all platforms
Below the command that I execute to start the build

`build-electron: yarn build-deps && yarn electron-webpack && yarn electron-builder -mwl --dir -c.compression=store -c.mac.identity=null`
The command above follows (as far as I'm aware) the guidelines provided by expo for the correct integration with electron

Thanks Guys!

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.