electron-userland / electron-userland/electron-webpack

Typescript causes compilation to fail

Open
#289 1 comment 0 reactions 0 assignees View on GitHub
Dominant language
TypeScript
Stars
902
Forks
168
PR merge metrics
No merged PRs in 30d

Description

I have a typescript react app that uses electron-webpack. My tsconfig.json looks like this:

```json
{
"extends": "./node_modules/electron-webpack/tsconfig-base.json",
"compilerOptions": {
"allowSyntheticDefaultImports": true,
"esModuleInterop": true,
"jsx": "react",
"baseUrl": ".",
"paths": {
"@/*": ["src/renderer/*"],
"@public/*": ["public/*"]
},
"module": "es2015",
"moduleResolution": "node",
"noImplicitAny": true,
"noImplicitThis": true,
"skipLibCheck": true,
"strictNullChecks": true,
"sourceMap": true,
"target": "esnext"
},
"include": ["./src"],
"exclude": ["node_modules"]
}
```

When running `electron-webpack --dev`, the application compiles just fine - even with typescript warnings. However, as soon as I run `electron-webpack`, the build will fail as soon as there are **any** typescript warnings.

Does `electron-webpack` not use the tsconfig.json file, or is it just more strict in production? It seems like the issue is with TSLint, which I don't use in my project - so is this something that is run during the compile step?

Its just super annoying that I can't even compile for little things such as unused variables, etc. Is there a way I can get around this, or a config file that I can change?

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.