electron-userland / electron-userland/electron-webpack
Building docs: The dist:dir command differs from the one in electron-webpack-quick-start/package.json
- Dominant language
- TypeScript
- Stars
- 902
- Forks
- 168
- PR merge metrics
- No merged PRs in 30d
Description
In the docs on the ["Building" page](https://webpack.electron.build/building) ([source](https://github.com/electron-userland/electron-webpack/blame/master/docs/en/building.md#L41)), there is the following `dist:dir` command:
"dist:dir": "yarn dist -- --dir -c.compression=store -c.mac.identity=null"
In the quick start repository the command is slightly different, see [package.json](https://github.com/electron-userland/electron-webpack-quick-start/blob/master/package.json#L9):
"dist:dir": "yarn dist --dir -c.compression=store -c.mac.identity=null"
The docs are from Sep 12, 2017, whereas the command in the quick start repository was updated at Oct 3, 2017 in [commit 10afade1bc8b25554ec906fa2bc01ca1aabf0228](https://github.com/electron-userland/electron-webpack-quick-start/commit/10afade1bc8b25554ec906fa2bc01ca1aabf0228#diff-b9cfc7f2cdf78a7f4b91a753d10865a2). Thus I think the docs need to be updated, but did not check it myself.
Contributor guide
No contributing guide indexed for this repository
Assessment
This issue has not been assessed yet.