electric-sql / electric-sql/electric

Support providing `secret` as header, not just a param, to avoid logging.

Open
#3,032 1 comment 0 reactions 0 assignees View on GitHub
Dominant language
TypeScript
Stars
10.4k
Forks
375
Avg merge
3d 1h
Merged PRs (30d)
18

Description

As per discussion here https://discord.com/channels/933657521581858818/933657523049885698/1408202901331120268 it seems helpful and sensible to support providing the secret as a header as well a query parameter.

Note that the HTTP spec currently requires as a param (unless running in insecure mode) https://electric-sql.com/openapi.html#/paths/~1v1~1shape/get

Notes:
- if we do this, I'm not sure if it's relevant to add the secret header to the vary header?

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.