electerious / electerious/ackee-lighthouse

Add .env property to allow to set more Browser flags

Open
#10 1 comment 0 reactions 0 assignees View on GitHub
help wanted
Dominant language
JavaScript
Stars
16
Forks
3
PR merge metrics
No merged PRs in 30d

Description

I used the tool locally and I missed the following feature to set a custom browser path:

```js
const createReports = async (endpoint, headers, events, urls, audit) => {
const additionalBrowserFlags = {};
if (process.env.BROWSER_PATH)
additionalBrowserFlags['chromePath'] = process.env.BROWSER_PATH;

const browser = await chromeLauncher.launch({
chromeFlags: ['--headless'],
...additionalBrowserFlags,
});
...
}
```

.env file:

```text
...
BROWSER_PATH=C:\\Program Files (x86)\\Microsoft\\Edge\\Application\\msedge.exe
...
```

A such configuration would allow to test with multiple Chromium based browser like in my case Edge.
What do you think? Would that be a proper enhancement?

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.