elastic / elastic/ruby-lumberjack

Improve server certificate validation in client

Open
#17 0 comments 0 reactions 0 assignees View on GitHub
enhancement
Dominant language
Ruby
Stars
3
Forks
17
PR merge metrics
No merged PRs in 30d

Description

The logstash-forwarder and filebeat certificate validation will also check the server certificate domain name. For openssl this check must be done by the library user after connecting to a server.

For FQDN validation of server certificate the client should use the servers certificate after the handshake (connect) to search for the domain name in the X.509 extension fields with fallback to the commonName field. This check is required to prevent potential man-in-the middle attacks.

The ruby openssl module already provides [post_connection_check](http://ruby-doc.org/stdlib-1.9.3/libdoc/openssl/rdoc/OpenSSL/SSL/SSLSocket.html#method-i-post_connection_check). But post_connection_check must be called by developer.

It should be possible to disable this check for testing purposes.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.