elastic / elastic/opentelemetry-lib

[enchrichment] support span eventName `error`

Open
#255 0 comments 1 reaction 0 assignees View on GitHub
Dominant language
Go
Stars
5
Forks
18
Avg merge
2d 12h
Merged PRs (30d)
7

Description

Should we support `error` event name in [addition to `exception`?](https://github.com/elastic/opentelemetry-lib/blob/main/enrichments/internal/elastic/span.go#L672)

[Semconv states](https://opentelemetry.io/docs/specs/semconv/exceptions/exceptions-spans/) the eventName must be `exception` however there seems to be a lot of usage of events with `error` `eventName` not being picked up. I experience this with the otel-demo, described in this issue https://github.com/open-telemetry/opentelemetry-demo/issues/2905.

A search also reveals some usages: https://github.com/search?q=span.AddEvent%28%22Error%22%2C+trace.WithAttributes%28+language%3AGo&type=code

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.