elastic / elastic/ml-cpp

[ML] Info and debug level log throttling

Open
#1,616 0 comments 0 reactions 0 assignees View on GitHub
:ml :ml/DataFrameAnalysis >enhancement
Dominant language
C++
Stars
157
Forks
67
Avg merge
12h 48m
Merged PRs (30d)
16

Description

#1615 introduces per log line rate based throttling of warn and error messages. We also have some message deduplication on the Java side: repeated lines are deduplicated. It is easier to reason about logging if all throttling occurs in one place. We also currently pay the price of writing the message over the named pipe to Java before deduplicating.

We should move debug and info level log throttling to C++ and remove the Java throttling we currently have. We should also decide whether we want to retain the old mechanism of only retaining the last line, move to per log line based throttling as we have for warn and error or not throttle at all for info and debug logging.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.