elastic / elastic/logstash

Pipeline viewer: Add an option to disable/mask field names in conditionals

Open
#9,433 3 comments 0 reactions 0 assignees View on GitHub
enhancement x-pack
Dominant language
Java
Stars
14.9k
Forks
3.5k
Avg merge
19h 14m
Merged PRs (30d)
63

Description

*Original comment by @suyograo:*

@bohyun-e brought up a good point today about security concerns around field names in the pipeline viewer. The only place I know that a field name or a config snippet is exposed is in the conditional UI component.

![pasted image at 2017_07_31 11_29 am](https://user-images.githubusercontent.com/1595958/28795568-36ea8ae2-75ef-11e7-8892-43ae5c0c11c9.png)

There could be customers who wouldn't want the field names shipped and exposed in the UI to all users. To this end, we should consider adding a granular config option (`xpack.monitoring.mask_field_names: true`) on x-pack-logstash to mask field names when shipping it.

I think the shape of the pipeline is still valuable with the masked conditional (at least the user knows there is a fork in the dataflow), so I'd prefer shipping `scrubbed` or some variation of it when this flag is allowed. I'd like to ship some value like `scrubbed` rather than skipping it entirely to differentiate this known scenario from any legit bug we have which would cause us to not ship data.

Thoughts?

/cc @acchen97 @bohyun-e @ycombinator @andrewvc

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.