elastic / elastic/logstash

Provide feedback to users when trying to install plugins that are dependencies of others

Open
#8,689 0 comments 0 reactions 0 assignees View on GitHub
enhancement plugin manager
Dominant language
Java
Stars
14.9k
Forks
3.5k
Avg merge
1d 4h
Merged PRs (30d)
88

Description

This is related to https://github.com/elastic/logstash/pull/4288

4288 is a nice add where we specify the dependent plugins when uninstalling a plugin. It can be helpful if we can extend this to the installation part. For example, the following will simply tell the user that it is locked at a version.

```
logstash-plugin install --version 9.0.0 logstash-output-elasticsearch
Validating logstash-output-elasticsearch-9.0.0
Installing logstash-output-elasticsearch
Plugin not found, aborting
ERROR: Installation Aborted, message: You have requested:
logstash-output-elasticsearch = 9.0.0
The bundle currently has logstash-output-elasticsearch locked at 7.4.0.
Try running `bundle update logstash-output-elasticsearch`
```

The uninstall command will show that the plugin has dependency on:

```
Failed to remove "logstash-output-elasticsearch" because the following plugins or libraries depend on it:

* logstash-input-couchdb_changes
* x-pack
```

The locking issue above is essentially due to a x-pack dependency. It will be helpful if we have a similar message as uninstallation so users will know to update a specific dependent plugin before they can install a later version of the plugin, etc..

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.