elastic / elastic/logstash

modules ssl.enabled settings expect string values only

Open
#8,580 2 comments 0 reactions 0 assignees View on GitHub
bug modules
Dominant language
Java
Stars
14.9k
Forks
3.5k
Avg merge
19h 14m
Merged PRs (30d)
63

Description

Currently the `ssl.enabled` settings for the elasticsearch and kibana module properties [do a comparison with the `"true"` string to determine if ssl should be enabled](https://github.com/elastic/logstash/blob/v5.6.3/logstash-core/lib/logstash/elasticsearch_client.rb#L32)

This works well if the settings are configured through the command line where everything is a string. But if the module is configured through the yaml setting, like, for example:

```yaml
modules:
- name: netflow
var.elasticsearch.hosts: "node01"
var.elasticsearch.ssl.enabled: true
```

Then the setting will have a boolean value instead of string, which means that regardless of true or false, the ssl won't be enabled.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.