elastic / elastic/logstash

Offline pack cannot force and update to a dependencies

Open
#8,170 3 comments 0 reactions 0 assignees View on GitHub
plugin manager v5.6.0 v6.0.0-rc1
Dominant language
Java
Stars
14.9k
Forks
3.5k
Avg merge
19h 14m
Merged PRs (30d)
63

Description

Installing a pack to upgrade existing plugins or a pack that come with an already installed dependency will fails.

**Scenario**
- update all the plugins on a local installation (LS 5.5.1)
- pack a plugin like `logstash-input-mongodb`
- the pack will come with an upgraded version of `stud`
- trying to install the pack in a freshly extract LS 5.5.1 will complaint that stud is already locked to a previous version.

**Debug message**
```
The bundle currently has stud locked at 0.0.22.
Try running `bundle update stud`
```

**Solution**

The problem is when we add [the new dependencies](https://github.com/elastic/logstash/blob/master/lib/pluginmanager/bundler/logstash_injector.rb#L82) to the Bundler's gem definition we never mark the gem as unlockable.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.