elastic / elastic/logstash

Plugin installation of specific version installs different version

Open
#7,397 3 comments 0 reactions 0 assignees View on GitHub
plugin manager
Dominant language
Java
Stars
14.9k
Forks
3.5k
Avg merge
19h 14m
Merged PRs (30d)
63

Description

Following this discussion: https://discuss.elastic.co/t/installing-x-pack-with-version-is-installing-the-wrong-version/87715

Hi!
If I install X-Pack on a Logstash 5.3.2 with this command:

/usr/share/logstash/bin/logstash-plugin install --version 5.3.0 x-pack

it installs version 5.3.2.

You will now say, that this is correct as I am using Logstash 5.3.2 but when using Puppet to do so you run in serious problems. What happens is:

I told puppet to install 5.3.0 (which is wrong)
* Puppet checked the version of the installed x-pack, as no x-pack is installed it comes back empty
* Puppet installes with the above command
* X-Pack v5.3.2 is installed

Next Puppet run:
* Puppet checks the version and gets v5.3.2 which is != v5.3.0
* Puppet installs v5.3.0 with above command, wich again install v5.3.2

This happens in an endles loop and restarts Logstash over and over everytime Puppet runs.

The help for the command "install" shows that there is a parameter --version which should be used to specify the version being installed.

So if I specify a version there it should install exactly that version or (even better) exit with an error. But just installing a different version is not correct and I think it is a bug.

Regards,
Alex

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.