elastic / elastic/logstash

Logstash-plugin generate test in the acceptance suite doesn't work

Open
#7,195 5 comments 0 reactions 0 assignees View on GitHub
test failure
Dominant language
Java
Stars
14.9k
Forks
3.5k
Avg merge
1d 4h
Merged PRs (30d)
88

Description

There is a few errors in theses examples:

1. The `File.directory?` check wont work because logstash is not a path
2. The install command won't work because the plugin is not build as a `*.gem` and the path is invalid.

This is a revert of https://github.com/elastic/logstash/pull/6879

```ruby
describe "on #{logstash.hostname}" do

GENERATE_TYPES = ["input", "filter", "codec", "output"]

GENERATE_TYPES.each do |type|
context "with type #{type}" do
it "successfully generate the plugin skeleton" do
command = logstash.run_command_in_path("bin/logstash-plugin generate --type #{type} --name qatest-generated")
expect(logstash).to File.directory?("logstash-#{type}-qatest-generated")
end
it "successfully install the plugin" do
command = logstash.run_command_in_path("bin/logstash-plugin install logstash-#{type}-qatest-generated")
expect(command).to install_successfully
expect(logstash).to have_installed?("logstash-#{type}-qatest-generated")
end
end
end
end
end

Contributor guide

Open the contributing guide

Research direction

Start with the acceptance-suite example in the issue and inspect the bin/logstash-plugin generate and install commands it invokes. Reproduce each plugin type, then verify that generation checks the actual output and that installation succeeds for the generated plugin.

Written by the indexing model from the issue text.

Assessment

Tech stack
ruby
Domain
testing-qa
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.