elastic / elastic/logstash

should tests rely on logstash.yml content?

Open
#7,189 1 comment 2 reactions 0 assignees View on GitHub
discuss
Dominant language
Java
Stars
14.9k
Forks
3.5k
Avg merge
19h 14m
Merged PRs (30d)
63

Description

as discussed in #6613 - I don't think our tests should rely on the `logstash.yml` actual content. Tests should rely on mocked/preset settings specific for these tests. For example, tweeking the local `logstash.yml` should not interfere with running the tests.

WDYT?

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.